Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next Millennium Bid Adapter: update to comply with Prebid v5 #7209

Merged
merged 5 commits into from
Aug 3, 2021
Merged

Next Millennium Bid Adapter: update to comply with Prebid v5 #7209

merged 5 commits into from
Aug 3, 2021

Conversation

mifanich
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

This adapter existed before.
We have made changes for approval to include it in v. 5.

  • test parameters for validating bids
{
    bidder: 'nextMillennium',
    params: {
        placement_id: '528'
    }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

@patmmccann
Copy link
Collaborator

Please unfollow your own branch in circleci so that our tests run, also remove changes to hello world.

@mifanich
Copy link
Contributor Author

I removed changes from hello_world.
Could you explain, how to unfollow my branch?

@mkendall07 mkendall07 requested a review from aleksatr July 26, 2021 17:48
@ChrisHuie ChrisHuie changed the title Next millennium bid adapter Next Millennium Bid Adapter: add new bid adapter Jul 27, 2021
@ChrisHuie ChrisHuie removed the request for review from aleksatr August 2, 2021 08:04
@ChrisHuie ChrisHuie self-requested a review August 2, 2021 08:04
@ChrisHuie ChrisHuie self-assigned this Aug 2, 2021
@ChrisHuie
Copy link
Collaborator

@mifanich inside circleci is should be in the drop-down panel to the left to unfollow your branch. Or if you give me edit access to this pr or the branch I can just kick off the test manually?

@mifanich
Copy link
Contributor Author

mifanich commented Aug 2, 2021 •
edited
Loading

@mifanich inside circleci is should be in the drop-down panel to the left to unfollow your branch. Or if you give me edit access to this pr or the branch I can just kick off the test manually?

@ChrisHuie I gave you access to the repo

@ChrisHuie
Copy link
Collaborator

@mifanich looks like you still need to add documentation for this pr. Docs should be added to this repo -> https://github.com/prebid/prebid.github.io

..and then also a markdown file in this pr that helps explain using your adapter. All details should be here that you may need (https://docs.prebid.org/dev-docs/bidder-adaptor.html) 🤘

@mifanich
Copy link
Contributor Author

mifanich commented Aug 3, 2021

@ChrisHuie Thank you, there is a PR doc
prebid/prebid.github.io#3169

@ChrisHuie ChrisHuie changed the title Next Millennium Bid Adapter: add new bid adapter Next Millennium Bid Adapter: update to comply with Prebid v5 Aug 3, 2021
@ChrisHuie
Copy link
Collaborator

@mifanich thanks.

@ChrisHuie ChrisHuie merged commit ca7ab18 into prebid:master Aug 3, 2021
@ChrisHuie ChrisHuie mentioned this pull request Aug 3, 2021
Merged
@mifanich mifanich deleted the nextMillennium-bid-adapter branch August 12, 2021 10:32
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
@ChrisHuie @agrandes-tappx
Next Millennium Bid Adapter: update to comply with Prebid v5 (prebid#…
72644c7 
…7209)

* Start

* nextMillenniumBidAdapter for v5

* add test page

* undo changes in hello_world

* manually kick off tests

Co-authored-by: Chris Huie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHuie ChrisHuie ChrisHuie approved these changes

Assignees

@ChrisHuie ChrisHuie

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mifanich @patmmccann @ChrisHuie @aleksatr